Skip to content

fix: fix typo of worker rules and controller rules#1492

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
jichenjc:bug/1475
Feb 27, 2023
Merged

fix: fix typo of worker rules and controller rules#1492
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
jichenjc:bug/1475

Conversation

@jichenjc
Copy link
Copy Markdown
Contributor

@jichenjc jichenjc commented Feb 24, 2023

What this PR does / why we need it:
Fixes: #1475

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2023
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 24, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit bf1ad3f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63f80dfa6c3f820007774540
😎 Deploy Preview https://deploy-preview-1492--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2023
@jichenjc jichenjc mentioned this pull request Feb 24, 2023
Closed
@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Feb 27, 2023

@mdbooth can you help review this? Thanks

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, mnaser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lentzi90
lentzi90 reviewed Feb 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Feb 27, 2023

/hold cancel

/cherry-pick v0.7

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Feb 27, 2023

@jichenjc: once the present PR merges, I will cherry-pick it on top of v0.7 in a new PR and assign it to you.

Details

In response to this:

/hold cancel

/cherry-pick v0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3c3c0bd into kubernetes-sigs:main Feb 27, 2023
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Feb 27, 2023

@jichenjc: cannot checkout v0.7: error checking out v0.7: exit status 1. output: error: pathspec 'v0.7' did not match any file(s) known to git

Details

In response to this:

/hold cancel

/cherry-pick v0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Feb 27, 2023

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 27, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Feb 27, 2023

@jichenjc: new pull request created: #1494

Details

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cwrau
Copy link
Copy Markdown
Contributor

cwrau commented Feb 27, 2023 •
edited
Loading

Sounds great! When can we expect a release? I was hoping for a quick 0.7.1?

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Feb 27, 2023

Sounds great! When can we expect a release? I was hoping for a quick 0.6.1?

I think 0.7.1 is on the way ....

@cwrau
Copy link
Copy Markdown
Contributor

cwrau commented Feb 27, 2023

Sounds great! When can we expect a release? I was hoping for a quick 0.6.1?

I think 0.7.1 is on the way ....

EDIT: Sorrey, typo 😅

@cwrau
Copy link
Copy Markdown
Contributor

cwrau commented Mar 7, 2023

Sounds great! When can we expect a release? I was hoping for a quick 0.6.1?

I think 0.7.1 is on the way ....

Since 0.7.1 is released but doesn't contain this fix as far as I can see, is there a timeline for 0.7.2?

@lentzi90
Copy link
Copy Markdown
Contributor

lentzi90 commented Mar 8, 2023

I guess we can start with back porting it to the release branch. Then it will at least get included in the next patch.

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Mar 8, 2023

@lentzi90: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api-provider-openstack#release-0.7 from head k8s-infra-cherrypick-robot:cherry-pick-1492-to-release-0.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-0.7 and k8s-infra-cherrypick-robot:cherry-pick-1492-to-release-0.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

I guess we can start with back porting it to the release branch. Then it will at least get included in the next patch.

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90
Copy link
Copy Markdown
Contributor

lentzi90 commented Mar 8, 2023

Ow sorry, it was already back-ported. Just not in the release. Then we wait I guess 🙂

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Mar 8, 2023

#1494 has been backported
I think we didn't include in 0.7.1 yet ..

@mdbooth mdbooth mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

+1 more reviewer

@mnaser mnaser mnaser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lentzi90 lentzi90

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Security group rule already exists - Update error.

6 participants

@jichenjc @k8s-ci-robot @k8s-infra-cherrypick-robot @cwrau @lentzi90 @mnaser